Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

interface-core pubsub subscribe fails in firefox #2662

Closed
1 task
hugomrdias opened this issue Dec 11, 2019 · 1 comment
Closed
1 task

interface-core pubsub subscribe fails in firefox #2662

hugomrdias opened this issue Dec 11, 2019 · 1 comment
Assignees
@SgtPooki
Labels
exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) kind/resolved-in-helia P2 Medium: Good to have, but can wait until someone steps up

Comments

@hugomrdias
Copy link
Member

hugomrdias commented Dec 11, 2019 •
edited
Loading

  • Version:
  • Platform:
  • Subsystem:

Type: Bug

Severity:Medium

Description:

Interface-core pubsub subscribe tests fail only firefox with secondary Go nodes.
We need to make sure JS works and investigate why Go fails.

look into https://github.com/ipfs/js-ipfs-http-client/blob/master/src/pubsub/subscribe.js#L27-L37 this might be a http-client issue instead

Steps to reproduce the error:

https://travis-ci.com/ipfs/js-ipfs/jobs/266025769#L1064
@hugomrdias hugomrdias added kind/bug A bug in existing code (including security flaws) exp/expert Having worked on the specific codebase is important P2 Medium: Good to have, but can wait until someone steps up labels Dec 11, 2019
This was referenced Dec 11, 2019
Merged
Closed
@achingbrain achingbrain mentioned this issue Sep 25, 2020
Closed
@SgtPooki SgtPooki self-assigned this May 17, 2023
@SgtPooki SgtPooki moved this to 🥞 Todo in js-ipfs deprecation May 17, 2023
@SgtPooki
Copy link
Member

js-ipfs is being deprecated in favor of Helia. You can learn more about this deprecation and read the migration guide.

Please feel to reopen with any comments by 2023-06-02. We will do a final pass on reopened issues afterwards (see #4336).

This should be resolved in Helia. If you were seeing this error with js-ipfs please try in Helia!

@github-project-automation github-project-automation bot moved this from 🥞 Todo to ✅ Done in js-ipfs deprecation May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SgtPooki SgtPooki

Labels
exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) kind/resolved-in-helia P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
js-ipfs deprecation
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hugomrdias @SgtPooki