This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: add default args for ipfs.add #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we don't send invalid args over http.
achingbrain
force-pushed
the
fix/add-default-args
branch
from
06d1619 to
2d2369b
Compare
hugomrdias
approved these changes
Mar 25, 2020
mistakia
pushed a commit
to mistakia/js-ipfs
that referenced
this pull request
Apr 3, 2020
So we don't send invalid args over http.
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
So we don't send invalid args over http.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we don't send invalid args over http. Also removes
nonatomicoption, not sure how that got in there.