This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: still load dag-pb, dag-cbor and raw when specifying custom formats #3132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we specify a `formats` array as part of the ipld options in in-proc nodes, it replaces the default list of dag-pb, dag-cbor and raw. This change allows the `loadFormat` function to still resolve those formats even if the user has passed a `format` array that does not contain them. Fixes #3129
|
Thanks @achingbrain :) |
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
…ts (#3132) If we specify a `formats` array as part of the ipld options in in-proc nodes, it replaces the default list of dag-pb, dag-cbor and raw. This change allows the `loadFormat` function to still resolve those formats even if the user has passed a `format` array that does not contain them. Fixes #3129
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we specify a
formatsarray as part of the ipld options in in-proc nodes, it replaces the default list of dag-pb, dag-cbor and raw.This change allows the
loadFormatfunction to still resolve those formats even if the user has passed aformatarray that does not contain them.Fixes #3129