Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

ipfs.bitswap.stat() should return who's peers are strings instead of CIDs #3389

Closed
Gozala opened this issue Nov 12, 2020 · 2 comments
Closed

ipfs.bitswap.stat() should return who's peers are strings instead of CIDs #3389

Gozala opened this issue Nov 12, 2020 · 2 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@Gozala
Copy link
Contributor

Gozala commented Nov 12, 2020

As per discussion here https://github.com/ipfs/js-ipfs/pull/3365/files/fa7c2c13c43bab922052104fe8aff863d9725e9b#r521321206 peers should be strings not CIDs
@Gozala Gozala added the need/triage Needs initial labeling and prioritization label Nov 12, 2020
@Gozala Gozala mentioned this issue Nov 12, 2020
Merged
@lidel
Copy link
Member

lidel commented Apr 26, 2021

@Gozala Is this still relevant given ongoing work in #2945 ?

@Gozala
Copy link
Contributor Author

Gozala commented Apr 26, 2021

As far as I can see this has not been addressed yet

js-ipfs/packages/ipfs-core/src/components/bitswap/stat.js

Line 23 in 63b11e5

peers: bitswap.peers().map(id => new CID(id.toB58String())),

So I'd say yes.

SgtPooki referenced this issue in ipfs/js-kubo-rpc-client Aug 18, 2022
@achingbrain @vasco-santos
chore: update buffer deps (#3607)
1a4df0b 
Updates deps to pull in Buffer@6.x.x

Refs #3604
Fixes #3389

Co-authored-by: Vasco Santos <vasco.santos@moxy.studio>
@snyk-bot snyk-bot mentioned this issue Oct 18, 2022
Open
@thexdesk thexdesk mentioned this issue Oct 18, 2022
Open
@zi3lak zi3lak mentioned this issue Oct 18, 2022
Open
@MarcelRaschke MarcelRaschke mentioned this issue Oct 19, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gozala @lidel