Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: enable upnp nat hole punching #3426

Merged
merged 8 commits into from
Jan 29, 2021
Merged

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Nov 26, 2020

On by default, set Swarm.DisableNatPortMap to true to disable.

Depends on:

Copy link

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming bundlesize: { maxSize: '527kB' }, is correct, then
LGTM

@achingbrain
Copy link
Member Author

Assuming bundlesize: { maxSize: '527kB' }, is correct

Sadly it is. About 10% of that is from ipfs-core, the rest is dependencies, mostly crypto libraries.

You can see the breakdown by running:

$ cd packages/ipfs-core
$ npm run build:js -- -b

@achingbrain achingbrain changed the title feat: add nat manager configuration options feat: enable upnp nat hole punching Jan 29, 2021
@achingbrain achingbrain merged commit 65dc161 into master Jan 29, 2021
@achingbrain achingbrain deleted the feat/enable-upnp-nat-punching branch January 29, 2021 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants