This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: do not republish self key twice #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/do-not-republish-self-key-twice
branch
from
bc76ddf to
1f336ea
Compare
vasco-santos
force-pushed
the
fix/do-not-republish-self-key-twice
branch
from
1f336ea to
26a46ec
Compare
vasco-santos
force-pushed
the
fix/do-not-republish-self-key-twice
branch
from
26a46ec to
1732fa8
Compare
achingbrain
reviewed
Apr 27, 2021
| }) | ||
| republisher._republishEntry = sinon.stub() | ||
|
|
||
| await republisher.start() |
There was a problem hiding this comment.
It is stopped in the afterEach (line 29), like remaining tests
achingbrain
reviewed
Apr 27, 2021
packages/ipfs-core/test/name.spec.js
Outdated
| expect(republisher._republishEntry.calledOnce).to.equal(false) | ||
|
|
||
| // Initial republish should happen after ~500ms | ||
| await delay(750) |
There was a problem hiding this comment.
Can we configure a smaller delay to make the tests faster?
There was a problem hiding this comment.
changed to 200 with initial broadcast of 100
There was a problem hiding this comment.
also decreased the other test timers
achingbrain
approved these changes
Apr 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPNS Republish was republishing self private key twice, first as part of the root IPNS Record published when creating the IPFS Repo and then as part of keychain keys.
This was specially problematic when doing a flow such as:
node packages/ipfs/src/cli.js init DEBUG=ipfs:i* node packages/ipfs/src/cli.js daemon --pass 12345678901234567890As we provided a keychain password for the daemon, this password was going to be used for creating the keychain dek. However, self was created as part of the PeerId in the init command (without password).