Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Cli block get pipe fix #903

Merged
merged 3 commits into from
Jul 8, 2017
Merged

Cli block get pipe fix #903

merged 3 commits into from
Jul 8, 2017

Conversation

kumavis
Copy link
Contributor

@kumavis kumavis commented Jul 7, 2017

  • disables execas's newline trimming for explicit newline testing
  • changes the cli block.get to not append an additional newline
  • adds an additional test for a block without a final newline

@kumavis
Copy link
Contributor Author

kumavis commented Jul 8, 2017

trifecta 👌

Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@daviddias daviddias merged commit 8063f6b into master Jul 8, 2017
@daviddias daviddias deleted the cli-block-get-pipe-fix2 branch July 8, 2017 08:06
@daviddias daviddias removed the status/in-progress In progress label Jul 8, 2017
dryajov pushed a commit that referenced this pull request Sep 1, 2017
* tests - cli - explicitly check newline presence

* cli - block.get - dont append newline

* test - cli - block - add test for block without final newline
MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this pull request May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants