Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

chore: skip ENS test if failing #2391

Merged
merged 1 commit into from
Aug 23, 2019
Merged

chore: skip ENS test if failing #2391

merged 1 commit into from
Aug 23, 2019

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Aug 23, 2019 •
edited
Loading

From IRC:

lidel: Moving it to permanent infrastructure, thats why its down atm.

Lets skip this (on failure) until service level improves.

chore: skip ENS test if failing
1d95367 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw alanshaw mentioned this pull request Aug 23, 2019
Merged
1 task
@achingbrain achingbrain mentioned this pull request Aug 23, 2019
Merged
1 task
achingbrain
achingbrain approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

lidel
lidel approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will restore this after ENS ships stable resolvers.

@alanshaw alanshaw merged commit beb2bd2 into master Aug 23, 2019
@alanshaw alanshaw deleted the chore/skip-ENS-test-if-fail branch August 23, 2019 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achingbrain achingbrain achingbrain approved these changes

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanshaw @lidel @achingbrain