-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The api is sometimes unresponsive when running in electron #230
Comments
I haven't been able to reproduce the issue. What os are you on? |
Arch Linux |
Anything I should try/any debug info that would be helpful? I'd be willing to help out with fixing this if I only knew where to begin :P |
@Powersource that would be awesome, any help is always welcome!
|
About to go to bed but I can already say that I haven't tried with a non-disposable repo for quite a while. Both the app and the linked example are set to disposable. |
Tried to replicate on my laptop (arch too, disposable nodes for now). I didn't manage to break it completely, but the 50% chance of it working correctly is still there. When it didn't work instantly it instead, very consistently, took very close to 1 minute (just below) to print id():
I'll try a non-disposable setup later. |
I tried with a non-disposable node iirc but that didn't help. However, I just now upgraded from electron 1.8.4 to electron 2.0.2 and it works great now! Most of the time instantly, sometimes takes a few seconds but probably not more than 10 at most. So happy this is fixed, I was going crazy 😂 🎉 🎉 🎉 There are a lot of bug fixes in the electron 2 announcement, not sure which one would have helped. There are 2 mentioning custom protocols but that seems to have been backported to 1.8.4. There's one about graceful shutdown on linux, might have been that one if the laptop in your profile pic @dryajov is a mac :P |
How to reproduce:
npm install
node index.js
id() should print every time.npm start
(i.e. electron) and open the console. id() prints around 25%-50% of the time.Been haunted by this bug or variations of it for quite some time.
The text was updated successfully, but these errors were encountered: