Add possibility to pass config options to local node and down to init() #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorb
reviewed
Oct 1, 2016
|
Fixed the tests. Ready to merge @victorbjelkholm or @diasdavid? |
|
@haadcode please rebase onto master |
- bug1: local var for the closure (this.subprocess set to null)
- bug2: order problem: should set .on('close') handler before .kill()
- now waits for "Daemon is ready" - also tracks Gateway address - checks failures on startup, and returns an error if so - this was a serious bug-- would not detect errors. - fails correctly, without leaving the process hanging
bugfixes and improvements (ipfs daemon flags)
This also stops the crash when stopping a daemon.
fix: do not crash on stopDaemon & upgrade to 0.4.3
update go-ipfs-dep to v0.4.3-2
|
I'm just gonna make a new, clean PR. Too much stuff in between has happened making it super hard to follow what actually changed here. New PR here: #123 |
|
Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will change the local() api so that options object can be passed to it.