Merge pull request #6144 from ipfs/feat/go1.12

Switch to Go 1.12

.circleci/config.yml

@@ -33,7 +33,7 @@ defaults: &defaults
     TRAVIS: 1
 
   docker:
-    - image: circleci/golang:1.11
+    - image: circleci/golang:1.12
 
 jobs:
   gotest:

coverage/main/main.go

@@ -43,15 +43,26 @@ func main() {
 		Pdeathsig: syscall.SIGTERM,
 	}
 
-	sig := make(chan os.Signal, 1)
+	sig := make(chan os.Signal, 10)
+	start := make(chan struct{})
 	go func() {
+		<-start
 		for {
 			p.Process.Signal(<-sig)
 		}
 	}()
+
 	signal.Notify(sig, syscall.SIGHUP, syscall.SIGINT, syscall.SIGTERM)
 
-	err = p.Run()
+	err = p.Start()
+	if err != nil {
+		fmt.Println(err.Error())
+		os.Exit(1)
+	}
+
+	close(start)
+
+	err = p.Wait()
 	if err != nil {
 		fmt.Println(err.Error())
 		os.Exit(1)

go.mod

@@ -115,3 +115,5 @@ require (
 	gopkg.in/gemnasium/logrus-airbrake-hook.v2 v2.1.2 // indirect
 	gotest.tools/gotestsum v0.3.3
 )
+
+go 1.12

mk/golang.mk

@@ -1,5 +1,5 @@
 # golang utilities
-GO_MIN_VERSION = 1.11.4
+GO_MIN_VERSION = 1.12
 export GO111MODULE=on