Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support go1.20 #10065

Closed
Jorropo opened this issue Aug 13, 2023 · 4 comments · Fixed by #10068
Closed

Support go1.20 #10065

Jorropo opened this issue Aug 13, 2023 · 4 comments · Fixed by #10068
Assignees

Comments

@Jorropo
Copy link
Contributor

Jorropo commented Aug 13, 2023

This is currently blocked due to this regression golang/go#60674

@Jorropo Jorropo mentioned this issue Aug 13, 2023
3 tasks
@lidel
Copy link
Member

lidel commented Aug 14, 2023

Triage notes:

  • we need to find a way to fix multipart on /api/v0 RPC (ideally, backward-compatible, if not, we need to make patch releases for all RPC client libraries) @hacdias

@aschmahmann
Copy link
Contributor

aschmahmann commented Aug 14, 2023

Note: this feels an awful lot like #8445 and ipfs/go-ipfs-files#42 (i.e. Go broke compatibility somewhere in the mimetype land, so we copy-paste code out of Go so we don't get forced to spend time on dealing with the breakages from this specific API on the Go team's schedule)

@hacdias hacdias mentioned this issue Aug 15, 2023
10 tasks
@hacdias
Copy link
Member

hacdias commented Aug 15, 2023

@aschmahmann the thing is that in ipfs/go-ipfs-files#42 it was just a few lines. Here it would be much more. We'd need the whole multipart reader, as well as copying the functions to convert an http.Response body to a multipart reader.

I think the path forward is to percent encode the names and make a patch release to the RPC client libraries (cc @Jorropo @lidel as this was discussed during triage).

@Jorropo
Copy link
Contributor Author

Jorropo commented Aug 15, 2023

I agree with %-encoding it, this is gonna break binary file paths with older clients but updating to a newer client will bring the feature back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants