Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: file upload functionality? #1819

Closed
prusnak opened this issue Oct 9, 2015 · 11 comments
Closed

gateway: file upload functionality? #1819

prusnak opened this issue Oct 9, 2015 · 11 comments
Labels
topic/gateway Topic gateway

Comments

@prusnak
Copy link
Contributor

prusnak commented Oct 9, 2015

Would it make sense to enable adding a file to node via HTTP POST/PUT request to gateway? This would enable IPFS to be used in lots of web applications that just need GET/PUT functionality. This option should not probably be default and could be enabled via a command line switch (similarly how unrestricted-api is enabled).

@jbenet
Copy link
Member

jbenet commented Oct 9, 2015

Yes, this used to be in and was removed to refactor. (Refactor didn't happen-- bad @cryptix). We should add it back in.

Should be a config option 

@whyrusleeping
Copy link
Member

yeah, we used to have it. But it was quite complicated... now that we have patch code, we can rewrite it using that to reenable the functionality

@whyrusleeping whyrusleeping added the topic/gateway Topic gateway label Oct 11, 2015
@cryptix
Copy link
Contributor

cryptix commented Oct 11, 2015

sorry... 😞

@prusnak
Copy link
Contributor Author

prusnak commented Oct 12, 2015

Seems to be implemented in #1543

@jbenet
Copy link
Member

jbenet commented Oct 14, 2015

@prusnak seems in need of rebase and fixes. i dont have time for it atm. maybe @ebuchman ? or someone else?

@rht
Copy link
Contributor

rht commented Oct 15, 2015

There is one #1845 but it depends on the add refactor to be merged.

@ebuchman
Copy link
Contributor

I can take a look again this weekend. Does #1845 allow one to upload a directory?

@rht
Copy link
Contributor

rht commented Oct 16, 2015

@ebuchman yes it does, see rht@545c07a#diff-19ceb36d78bde310c54cc44a95bec44cR269. Sorry for reinventing your PR.

@rht
Copy link
Contributor

rht commented Oct 16, 2015

Currently the added node is pinned by default (will add option for this).

@rht rht mentioned this issue Oct 16, 2015
5 tasks
@davidar
Copy link
Member

davidar commented Oct 20, 2015

@jbenet will this enable https://botbot.me/freenode/ipfs/msg/50741140/ ?

@prusnak
Copy link
Contributor Author

prusnak commented Jan 18, 2016

As this was implemented in merge from #1845 I am closing this issue.

There is a multipart issue tracked here: #2205

@prusnak prusnak closed this as completed Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/gateway Topic gateway
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants