Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass metrics collection through the root context of an ipfs node #3212

Open
whyrusleeping opened this issue Sep 12, 2016 · 0 comments
Open

Pass metrics collection through the root context of an ipfs node #3212

whyrusleeping opened this issue Sep 12, 2016 · 0 comments
Labels
help wanted Seeking public contribution on this issue status/deferred Conscious decision to pause or backlog

Comments

@whyrusleeping
Copy link
Member

After #3189 lands, we are starting to use contexts to perform metrics collection. To really make this nice, we should pass the metrics collector down through the context chain. Doing so will make metrics collection throughout the codebase much easier to test and reason about.

This will require us to fix: jbenet/goprocess#16
This was referenced Sep 12, 2016
Merged
Open
@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Sep 14, 2016
@flyingzumwalt flyingzumwalt added the status/deferred Conscious decision to pause or backlog label Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue status/deferred Conscious decision to pause or backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flyingzumwalt @whyrusleeping