Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keys from keystore are not republished to DHT #3537

Closed
Kubuxu opened this issue Dec 25, 2016 · 4 comments
Closed

Keys from keystore are not republished to DHT #3537

Kubuxu opened this issue Dec 25, 2016 · 4 comments
Labels
kind/bug A bug in existing code (including security flaws)
Milestone
Ipfs 0.4.11

Comments

@Kubuxu
Copy link
Member

Kubuxu commented Dec 25, 2016

Needs to be added to node.IpnsRepub.AddName.

We need to probably also store the last published entry to keep it through node resets.
@Kubuxu Kubuxu added the kind/bug A bug in existing code (including security flaws) label Dec 25, 2016
@Kubuxu Kubuxu added this to the ipfs 0.4.6 milestone Dec 25, 2016
@Kubuxu Kubuxu mentioned this issue Dec 26, 2016
Merged
@wigy-opensource-developer
Copy link

wigy-opensource-developer commented Dec 26, 2016 •
edited
Loading

Thanks, Kuba. I just added a comment to #3472 about this missing part. Actually, it is not just the public keys, but the IPNS records that need to be republished.

Closed
@whyrusleeping whyrusleeping modified the milestones: Ipfs 0.4.7, ipfs 0.4.6 Feb 17, 2017
@whyrusleeping whyrusleeping modified the milestones: Ipfs 0.4.8, Ipfs 0.4.7 Mar 11, 2017
@whyrusleeping
Copy link
Member

Lets definitely try and get this done in 0.4.8, Don't want the keystore feature to remain semi-gimped for long

@whyrusleeping whyrusleeping modified the milestones: Ipfs 0.4.9, Ipfs 0.4.8 Mar 24, 2017
@whyrusleeping
Copy link
Member

more discussion in #3808

@whyrusleeping whyrusleeping modified the milestones: Ipfs 0.4.10, Ipfs 0.4.9 May 8, 2017
@magik6k magik6k modified the milestones: Ipfs 0.4.10, Ipfs 0.4.11 Jul 28, 2017
@whyrusleeping
Copy link
Member

@Kubuxu this is done now, right?

@Kubuxu Kubuxu closed this as completed Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
Ipfs 0.4.11
Development

No branches or pull requests
4 participants
@whyrusleeping @wigy-opensource-developer @Kubuxu @magik6k