Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Bandwidth #4476

Closed
Stebalien opened this issue Dec 10, 2017 · 1 comment · Fixed by #4610
Closed

Incorrect Bandwidth #4476

Stebalien opened this issue Dec 10, 2017 · 1 comment · Fixed by #4610

Comments

@Stebalien
Copy link
Member

Our custom build of go-metrics ticks every 1 second (so we get faster bandwidth statistics updates) but still averages assuming that it ticks every 5 seconds. This give us wildly incorrect bandwidth metrics (off by a factor of 5).

I'm currently fixing this by getting rid of go-metrics (it's overcomplicated, slow, and poorly implemented).
@Stebalien
Copy link
Member Author

go-metrics has been replaced. Waiting to bubble up the fix.

This was referenced Jan 26, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mega update ipfs/kubo
1 participant
@Stebalien