[meta] better sharness coverage

[Stebalien]

This list is a work in progress. Suggestions appreciated.

General

For all commands, we should:

• Check that --help works.
• Check that bad flags are correctly detected.

CID formatting

For all commands that have CID formatting options (add, block put, dag put, etc.), we check that:

• --mhtype=notSha256 --cid-version=0 fails (--cid-version=0 is sometimes written as --format=v0).
• --mhtype=notSha256 defaults to CIDv1.
• --mhtype=sha256 --cid-version=0 works.
• --mhtype=anyHash --cid-version=1 works.

Get directory

Check the directories:

• ipfs get /ipfs/QmDir/
• ipfs get /ipfs/QmDir
• ipfs get /ipfs/QmDir/otherDir/
• ipfs get /ipfs/QmDir/otherDir
• ipfs get /ipfs/QmDir/otherDir/secondDir
• ipfs get /ipfs/QmDir/otherDir/secondDir/

Containing:

• Nothing
• A single file
• A hidden file.
• A directory.
• A hidden directory.
• Some tree of files.

(and ensure that we actually get the right output).

Get file

Check that the following fail:

• ipfs get /ipfs/QmFile/
• ipfs get /ipfs/QmDir/QmFile/

[whyrusleeping]

Hey @chriscool, wanna help us out a bit?

[chriscool]

@whyrusleeping Yeah sure I will take a look at this later today.

[chriscool]

@Stebalien about all commands accepting --help, there is such a test already:

https://github.com/ipfs/go-ipfs/blob/master/test/sharness/t0010-basic-commands.sh#L64-L75

[Stebalien]

about all commands accepting --help, there is such a test already:

Ah, nice! However, we need to not pipe /dev/null to stdin. See #4837.

[chriscool]

@Stebalien do you mean that there should be the same tests with echo stuff | $cmd --help >/dev/null or just $cmd --help >/dev/null?

[Stebalien]

Both might actually be a good idea.

[kevina]

I would add:

• --cid-version=1 enabled raw-leaves by default when applicable

[chriscool]

@Stebalien please take a look at:

#4849
#4848

[chriscool]

@whyrusleeping please take a look at merging the above 2 PRs!

[whyrusleeping]

@chriscool merged!