Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor blockstore to work with bare multihashes instead of CIDs #5231

Closed
kyledrake opened this issue Jul 13, 2018 · 3 comments
Closed

Refactor blockstore to work with bare multihashes instead of CIDs #5231

kyledrake opened this issue Jul 13, 2018 · 3 comments
Labels
topic/blockstore Topic blockstore topic/cidv1b32 Topic cidv1b32

Comments

@kyledrake
Copy link

This is needed to prevent issues with blockstore data duplication when different CIDs are provided for the same multihash.

The "quick fix" version is to check for both, but a proper conversion and migration would be better for preventing dupes.

https://github.com/ipfs/ipfs/issues/337

@kevina
@magik6k magik6k added topic/cidv1b32 Topic cidv1b32 topic/blockstore Topic blockstore labels Jul 14, 2018
@kevina kevina self-assigned this Jul 15, 2018
@kevina
Copy link
Contributor

kevina commented Jul 29, 2018

See #5285 for the "quick fix".

@kevina
Copy link
Contributor

kevina commented Jul 29, 2018

See ipfs/boxo#361 for a discussion on what the new interface should be.

This was referenced Aug 7, 2018
Closed
Open
@Mr0grog Mr0grog mentioned this issue Aug 20, 2018
Merged
@kevina kevina mentioned this issue Sep 22, 2018
Merged
@magik6k magik6k mentioned this issue May 8, 2019
Closed
@lidel
Copy link
Member

lidel commented Sep 29, 2021

Continued in #6815

@lidel lidel closed this as completed Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/blockstore Topic blockstore topic/cidv1b32 Topic cidv1b32
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kyledrake @lidel @kevina @magik6k