Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make go-ipfs-source.tar.gz fails on master #5859

Closed
chris05atm opened this issue Dec 19, 2018 · 0 comments
Closed

make go-ipfs-source.tar.gz fails on master #5859

chris05atm opened this issue Dec 19, 2018 · 0 comments
Labels
kind/bug A bug in existing code (including security flaws) topic/build Topic build

Comments

@chris05atm
Copy link

Version information:

go-ipfs commit on master 3f6925d

On MacOS

Type: "bug"

Description:

mk/tarball.mk contains logic that breaks on MacOS. Mac's readlink -f is not compatible with what you'd see on a Linux system unfortunately.

cd $GOPATH/src/
mkdir -p ipfs/go-ipfs && cd $_
git clone https://github.com/ipfs/go-ipfs.git
git checkout 3f6925d # (tip of master just now)
make go-ipfs-source.tar.gz

Instead of doing the right thing the command fails due to -f behaving differently than expected across platforms.

@Stebalien Stebalien added kind/bug A bug in existing code (including security flaws) topic/build Topic build labels Dec 19, 2018
@magik6k magik6k added help wanted Seeking public contribution on this issue and removed help wanted Seeking public contribution on this issue labels Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) topic/build Topic build
Projects
None yet
Development

No branches or pull requests

3 participants