Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin ls should stream the result #6304

Closed
MichaelMure opened this issue May 7, 2019 · 5 comments
Closed

pin ls should stream the result #6304

MichaelMure opened this issue May 7, 2019 · 5 comments
Labels
help wanted Seeking public contribution on this issue topic/commands Topic commands topic/core-api Topic core-api

Comments

@MichaelMure
Copy link
Contributor

Version information:

go-ipfs version: 0.4.20-
Repo version: 7
System version: amd64/linux
Golang version: go1.12.4

Type: enhancement

Description:

pin ls build the full result before starting to send the result. With a big repository (~1TB, millions of recursive pins), this means that the command start to output something after one hour.

It should be entirely possible to stream that result:

  • output all the direct pins while adding them to the set
  • output all the recursive pins while adding them to the set, ignore those already in the set
  • walk the content graph from the recursive pins to get the indirect pins, ignore those already in the set
@magik6k
Copy link
Member

magik6k commented May 8, 2019

I picked this up at one point - #5005, but it's so outdated that it's probably easier to redo this from scratch

@magik6k magik6k added topic/commands Topic commands topic/core-api Topic core-api help wanted Seeking public contribution on this issue labels May 8, 2019
@MichaelMure
Copy link
Contributor Author

Updated PR: #6493

@Stebalien
Copy link
Member

Thanks! Closing.

@Stebalien Stebalien reopened this Jul 10, 2019
@Stebalien
Copy link
Member

Sorry, closing the outdated PR (#5005).

@MichaelMure
Copy link
Contributor Author

#6493 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue topic/commands Topic commands topic/core-api Topic core-api
Projects
None yet
Development

No branches or pull requests

3 participants