We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It is possible for user to set 0 in cfg.ResourceMgr.Limits and for it to set a zero when the go-libp2p resource manager is enabled.
We should provide users with a way to do a hard block on certain resource usage within go-libp2p via Kubo config (e.g., block this specific peer).
Apply (https://github.com/libp2p/go-libp2p/blob/master/p2p/host/resource-manager/limit.go#L102 ) overrides any 0 value. In https://github.com/ipfs/kubo/blob/master/core/node/libp2p/rcmgr.go#L66, that means that any user-supplied override will be replaced by computed defaults. I don't know the right place to fix this. I created #9563 to at least make the situation clearer.
The text was updated successfully, but these errors were encountered:
There is no more planned work on this specifically given:
ResourceMgr.Limits
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Done Criteria
It is possible for user to set 0 in cfg.ResourceMgr.Limits and for it to set a zero when the go-libp2p resource manager is enabled.
Why Important
We should provide users with a way to do a hard block on certain resource usage within go-libp2p via Kubo config (e.g., block this specific peer).
Notes
Apply (https://github.com/libp2p/go-libp2p/blob/master/p2p/host/resource-manager/limit.go#L102 ) overrides any 0 value. In https://github.com/ipfs/kubo/blob/master/core/node/libp2p/rcmgr.go#L66, that means that any user-supplied override will be replaced by computed defaults.
I don't know the right place to fix this.
I created #9563 to at least make the situation clearer.
The text was updated successfully, but these errors were encountered: