repo: add ipfs repo stat command
#2289
Conversation
|
@whyrusleeping Can you ping me on all of these 'add commands to ipfs' PRs? I'll need to update the API when they happen. |
|
|
||
| var repoStatCmd = &cmds.Command{ | ||
| Helptext: cmds.HelpText{ | ||
| Tagline: "Print status of the local repo", |
|
There were the following issues with your Pull Request
We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity. This message was auto-generated by https://gitcop.com |
| } | ||
|
|
||
| count := uint64(0) | ||
| for range allKeys { |
There was a problem hiding this comment.
hrm... this is awkward. I think this is actually the best way of doing this, short of traversing the directory and listing all the files
|
I like this, although it takes an unfortunately long time on my repo with 500GB worth of content. Nothing is the fault of your code, thats just things we need to optimize on the flatfs datastore side. I'll give this another lookover tomorrow, but i think getting some feedback from @rht would be good on this, he's done a lot of work in this area. |
License: MIT Signed-off-by: Thomas Gardner <tmg@fastmail.com>
License: MIT Signed-off-by: Thomas Gardner <tmg@fastmail.com>
License: MIT Signed-off-by: Thomas Gardner <tmg@fastmail.com>
License: MIT Signed-off-by: Thomas Gardner <tmg@fastmail.com>
|
@tomgg Why did you close this? |
|
because his code got merged in #2430, @diasdavid finished off the PR for him and added a couple tests. |
A step in the direction of #1744.
Line 134 probably needs the attention of a Go pro.