feat(eventlog): e := EventBegin; e.Done() #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
btc
commented
Jan 14, 2015
btc
commented
|
|
|
Im so excited for this. |
btc
force-pushed
the
feat/eventlogBeginDone
branch
2 times, most recently
from
a9d8430 to
1aad832
Compare
|
@briantigerchow Do you want to merge this soon? Im going to start working it into the rest of the codebase |
```Go e := log.EventBegin(ctx, "provide") e.Done() e := log.EventBegin(ctx, "provide") e.Close() // implements io.Closer in case you want to register with some lifecycle management system. ```
btc
force-pushed
the
feat/eventlogBeginDone
branch
from
1aad832 to
b252d04
Compare
btc
pushed a commit
that referenced
this pull request
Jan 15, 2015
feat(eventlog): e := EventBegin; e.Done()
|
@whyrusleeping merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.