You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now rainbow allows deserialized responses for all domains, so the limiting of response types to trustless car/block/ipns-record on that domain is done at Nginx, which is a bit janky.
For example, it does support Accept: application/vnd.ipld.car but errors on ?format=car, which is a bug we need to fix eventually.
Solution
I believe explicit is better than implicit here.
Initial idea: We already have RAINBOW_SUBDOMAIN_GATEWAY_DOMAINS. Add similar, explicit RAINBOW_TRUSTLESS_GATEWAY_DOMAINS which limits specified domains to only support trustless responses, and return HTTP 400 Bad Request for everything else, and use it with trustless-gateway.link
Problem
Accept: application/vnd.ipld.car
but errors on?format=car
, which is a bug we need to fix eventually.Solution
I believe explicit is better than implicit here.
Initial idea: We already have
RAINBOW_SUBDOMAIN_GATEWAY_DOMAINS
. Add similar, explicitRAINBOW_TRUSTLESS_GATEWAY_DOMAINS
which limits specified domains to only support trustless responses, and return HTTP 400 Bad Request for everything else, and use it with trustless-gateway.linkcc @ns4plabs @hacdias
The text was updated successfully, but these errors were encountered: