Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flesh out how we use gateway-conformance for testing subdomain and path modes #181

Closed
Tracked by #31
SgtPooki opened this issue Apr 8, 2024 · 2 comments
Closed
Tracked by #31
Milestone

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Apr 8, 2024

@lidel @achingbrain

I'm going to be moving gateway conformance tests code into @helia/verified-fetch.

That will likely require:

  1. setting up a basic gateway host (I'm imagining a basic nodejs http server that passes requests directly to verified-fetch)
  2. setting up subdomain gateway for testing environment (i.e. porting over reverse-proxy.js from this repo)
  3. setting up gateway conformance fixture loading in helia-verified-fetch repo (pulling logic from helia-http-gateway and service-worker-gateway repos)

Once that is done, we should be able to get away with just CI tests in helia-http-gateway and service-worker-gateway.

Are you two okay with this plan?

@SgtPooki SgtPooki changed the title TODO: flesh out how we use gateway-conformance for testing subdomain and path modes flesh out how we use gateway-conformance for testing subdomain and path modes Apr 8, 2024
@SgtPooki SgtPooki added this to the Beta milestone Apr 8, 2024
@lidel
Copy link
Member

lidel commented Apr 15, 2024

Sgtm. Focus on verified-fetch, where nearly all of relevant code related to web pathing and ipfs:// behaviors will live.

@SgtPooki
Copy link
Member Author

SgtPooki commented Apr 25, 2024

I am going to call this closed since this issue is basically tracking agreement on how to proceed. #224 tracks completion of the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants