fix: revert "feat: migrate to preact/compat (#190)" #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix: revert "feat: migrate to preact/compat (#190)"
Description
This reverts commit 8c98f57 from PR #190
Notes & open questions
I believe this was causing some issues in deployed environments.. I was also able to reproduce some errors locally with
http-server
andnpm start
.. Issues include:Apparently preact support is not quite where we need it with webpack 5, or we need to do some additional config. Considering the large reduction in final asset size, it was worth a try, but reverting now because potential pains & incompatibility are not worth it.
We can potentially investigate this further later, but we would need some way to reproduce these errors consistently and write some test to catch those failures.
Change checklist