Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "feat: migrate to preact/compat (#190)" #219

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Apr 24, 2024

Title

fix: revert "feat: migrate to preact/compat (#190)"

Description

This reverts commit 8c98f57 from PR #190

Notes & open questions

I believe this was causing some issues in deployed environments.. I was also able to reproduce some errors locally with http-server and npm start.. Issues include:

  1. not being able to find css/js assets consistently
  2. CMD+SHIFT+R resulting in renderable content, CMD+R resulting in missing assets and failed loading
  3. css file not found for config page when attempting to load subdomain config page directly (found when trying to look into bug: meaningful error page bug on reading body #218)

Apparently preact support is not quite where we need it with webpack 5, or we need to do some additional config. Considering the large reduction in final asset size, it was worth a try, but reverting now because potential pains & incompatibility are not worth it.

We can potentially investigate this further later, but we would need some way to reproduce these errors consistently and write some test to catch those failures.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@SgtPooki SgtPooki merged commit 4443174 into main Apr 24, 2024
23 checks passed
@SgtPooki SgtPooki deleted the fix/revert-preact-migration branch April 24, 2024 20:18
@lidel lidel mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant