feat: about section on subdomain loads #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
feat/about-on-subdomains
branch
from
05ca132
to
55879c1
Compare
Without this people see confusing button to click, and some configuration, but have no idea what is happening.
lidel
force-pushed
the
feat/about-on-subdomains
branch
from
55879c1
to
d86c1ae
Compare
Merged
2color
added a commit
that referenced
this pull request
Jun 14, 2024
* chore(main): release 1.2.0 (#216) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: about section on subdomain loads (#263) Without this people see confusing button to click, and some configuration, but have no idea what is happening. Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com> * fix: remove fonts except woff2 (#282) * fix: add purgecss webpack plugin * fix: keep only woff2 font, remove purgeCss * chore: improve LCP performance (#293) --------- Co-authored-by: Marcin Rataj <lidel@lidel.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Norman <1992255+2color@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves "about" into separate component and reuses it on subdomain landing page displayed when SW is not registered yet.
This aims to fix UX problem when I send https://en-wikipedia--on--ipfs-org.ipns.inbrowser.dev to someone, and all they see is no wikipedia, but a confusing button to click, and some configuration, but have no idea what is happening.
Feedback welcome, preview below:
Before
After