Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPIP: path gateway - range requests clarification (nit) #465

Closed
SgtPooki opened this issue Mar 4, 2024 · 1 comment
Closed

IPIP: path gateway - range requests clarification (nit) #465

SgtPooki opened this issue Mar 4, 2024 · 1 comment

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Mar 4, 2024

`Range` can be used for requesting specific byte range of UnixFS files and raw
blocks.

Should we be supporting range requests for identity blocks as well?

ipfs-unixfs-exporter has support for these: https://github.com/search?q=repo%3Aipfs%2Fjs-ipfs-unixfs%20path%3Apackages%2Fipfs-unixfs-exporter%20validateOffsetAndLength&type=code

@lidel
Copy link
Member

lidel commented Mar 27, 2024

Good question. An inlined block, once "deserialized from identity Multihash" is a valid UnixFS file (it can be dag-pb or raw), so I think the spec covers them.

Good that we support them, (very useful for tests and health-checks), but also unlikely anyone will request range of such small data in real world :)

@lidel lidel closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants