Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/routing/v1: add missing HTTP cache headers #466

Merged
merged 4 commits into from
Mar 22, 2024
Merged

/routing/v1: add missing HTTP cache headers #466

merged 4 commits into from
Mar 22, 2024

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 7, 2024

Request from ipfs/boxo#584.

@hacdias hacdias requested a review from lidel March 7, 2024 11:48
@hacdias hacdias self-assigned this Mar 7, 2024
@hacdias hacdias force-pushed the response-headers branch from a6cf746 to 935cea4 Compare March 7, 2024 11:53
@hacdias hacdias changed the title routing: add missing cache headers routing: add missing repsonse headers Mar 7, 2024
@hacdias hacdias changed the title routing: add missing repsonse headers routing: add missing response headers Mar 7, 2024
@hacdias hacdias force-pushed the response-headers branch from 935cea4 to db6d950 Compare March 7, 2024 11:55
src/routing/http-routing-v1.md Outdated Show resolved Hide resolved
src/routing/http-routing-v1.md Outdated Show resolved Hide resolved
lidel and others added 2 commits March 18, 2024 23:26
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
@lidel lidel changed the title routing: add missing response headers /routing/v1: add missing HTTP cache headers Mar 22, 2024
@lidel lidel force-pushed the response-headers branch from 318782f to 814166d Compare March 22, 2024 19:48
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added some references to RFC and the rationale behind TTL.
Merging (we can refine later, but better to have HTTP caching headers in the spec).

@lidel lidel merged commit 6783eaa into main Mar 22, 2024
4 checks passed
@lidel lidel deleted the response-headers branch March 22, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

3 participants