-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing on Node.js Windows "current" #94
Comments
Looks like the last successful job here was https://github.com/ipld/codec-fixtures/actions/runs/5458983079/job/14778794547 running against 239f3b0 |
Diff of repo between action runs: 239f3b0...01ec64d Some other details:
|
hah, escaping, how does it even work? https://github.com/ipld/codec-fixtures/blob/master/.github/workflows/cron.yml#L28 Last successful run you identified has a date of Jul 5, which coincides with the Node.js 20.4.0 release, same day, so subsequent runs would be picking up that new one as "current" and failing. So it's something in that release that has messed up Windows: https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V20.md#2023-07-05-version-2040-current-rafaelgss |
Arrr, thar she is: nodejs/node#48673, fixed in libuv/libuv#4092, but needs a release of libuv and Node to get it fixed here. Well that takes the pressure off, but failures aren't awesome to deal with. |
finally landed in nodejs main nodejs/node#50650, should be in the next current release |
Some unicode filename thing that's now popping up, either Node.js latest change or something to do with the Windows deployment in CI: https://github.com/ipld/codec-fixtures/actions/runs/5756528910/job/15606085523
The text was updated successfully, but these errors were encountered: