Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor cidlink.Memory to use storage API (and disappear) #275

Open
warpfork opened this issue Oct 22, 2021 · 0 comments
Open

refactor cidlink.Memory to use storage API (and disappear) #275

warpfork opened this issue Oct 22, 2021 · 0 comments
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P3 Low: Not priority right now

Comments

@warpfork
Copy link
Collaborator

See #266 (comment) -- this should be possible now, because the APIs it would depend on have landed.

This should result in a bit more code reuse. I suspect the additional struct type should disappear entirely. There may be a helper method that appears instead, to construct a similar behavior? Not sure exactly.
@warpfork warpfork added help wanted Seeking public contribution on this issue good first issue Good issue for new contributors exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now effort/hours Estimated to take one or several hours labels Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P3 Low: Not priority right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@warpfork