Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoice Tags only populate 1st time on collection assignment #24

Open
rsafier opened this issue Aug 27, 2024 · 2 comments
Open

Invoice Tags only populate 1st time on collection assignment #24

rsafier opened this issue Aug 27, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@rsafier
Copy link
Contributor

rsafier commented Aug 27, 2024

When setting field such as Features and RoutingInfos the tags are generated only on assignment of collection. This pattern is not completely obvious to consumer.
Would be nicer if dynamically built tags only on encode, or provide helper extension methods that abstract that away e.g. Invoice.AddFeatureFlag(x) invoice.AddRouteHint(x)

@nGoline nGoline added the bug Something isn't working label Nov 21, 2024
@nGoline nGoline self-assigned this Nov 21, 2024
@nGoline
Copy link
Contributor

nGoline commented Feb 13, 2025

This behavior was already a problem to me on the first iteration. I'm changing it to meet the expectations, meaning when you change the Features and/or RoutingInfo the string is re-computed.

@nGoline
Copy link
Contributor

nGoline commented Feb 13, 2025

I still think there's room for improvement, like:

  • Should we allow for replacing such fields completely (re-assigning the collection)?
  • What about other fields?

I welcome any input on this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants