Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fix: cleanup after a reboot #1322

Closed
ipspace opened this issue Sep 20, 2024 · 3 comments
Closed

Doc fix: cleanup after a reboot #1322

ipspace opened this issue Sep 20, 2024 · 3 comments
Labels
1.9.2 documentation Improvements or additions to documentation

Comments

@ipspace
Copy link
Owner

ipspace commented Sep 20, 2024

We should mention somewhere that it's best to shut down the labs before powering off the server, and described the cleanup procedure.

Originally posted by @matthoug in #1321

@jbemmel
Copy link
Collaborator

jbemmel commented Sep 23, 2024

Could consider to set https://containerlab.dev/manual/nodes/#auto-remove on VMs

@ipspace
Copy link
Owner Author

ipspace commented Sep 24, 2024

Could consider to set https://containerlab.dev/manual/nodes/#auto-remove on VMs

That just sets the '--rm' flag. It won't clean up Docker networks or other artifacts like clab_files or other directories containerlab creates. The only way to do a proper cleanup is to run 'netlab down --cleanup'

@ipspace ipspace added the documentation Improvements or additions to documentation label Sep 26, 2024
@jbemmel
Copy link
Collaborator

jbemmel commented Oct 1, 2024

Could consider to set https://containerlab.dev/manual/nodes/#auto-remove on VMs

That just sets the '--rm' flag. It won't clean up Docker networks or other artifacts like clab_files or other directories containerlab creates. The only way to do a proper cleanup is to run 'netlab down --cleanup'

It also prevents setting the restart policy for Linux containers: https://github.com/srl-labs/containerlab/blob/main/runtime/docker/docker.go#L506

But you are right - it doesn't cleanup everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.9.2 documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants