Push state in comm open msg #84
Conversation
|
js tests appear to be failing. |
|
Hmmm strange, I'm really not sure why this is failing. I'll debug locally. |
|
Ahhh forgot |
| }).catch(utils.reject("Couldn't create a model.", true)); | ||
| // For < 4.x | ||
| var model; | ||
| if (msg.content.data.model_name) { |
There was a problem hiding this comment.
In which case could this happen? Is this to handle an older version of the Python side?
There was a problem hiding this comment.
How do you see this occurring ?
There was a problem hiding this comment.
the removal of this did break Interact.jl fwiw. probably good to have a deprecation for such things before breaking changes.
There was a problem hiding this comment.
I think we broke it in a later commit, sorry @shashi ! @SylvainCorlay and I will try to be better about things like this. It was removed in 474f08c
There was a problem hiding this comment.
I don't quite understand the whole process but that sounds like an awful lot of things to support. But yeah, if you want to do it, I won't say no :) I'd be happy if I had the good stack traces back, though.
There was a problem hiding this comment.
I think that for each registered kernel, we should have the Javascript in a different directory, (one per installed kernelspec). The requirejs path would be automatically prefixed with a string corresponding to the current kernel.
I think this is a good idea and I'm +1 for it - it should be addressed with the other packaging problems https://jupyter.hackpad.com/Packaging-crate-PbIgxnC71or . @shashi with the feature @SylvainCorlay is describing, packaging would be more like npm. You, in the Julia widgets, would depend on a specific widget JS version X. That would allow us to continue chugging along without affecting you, and when you were ready to upgrade, you could.
@SylvainCorlay despite that, I still think for things like this, which are "widget msg spec" changing, we need deprecation warnings. Julia (@shashi) and Haskell (@sumitsahrawat) implementations both exist now, and we should do our best to help them transition to our latest Javascript.
There was a problem hiding this comment.
I know deprecation warnings can be a pain to keep track of, but I think they are much less of a pain for us than it is for our friends to migrate without them.
There was a problem hiding this comment.
@jdfreder thanks, I will look at the hackpad.
|
@jdfreder this seems to be breaking a simple example such as from ipywidgets import *
HBox([Button()]) |
|
Fixed in #86. |
github-actions
bot
added
the
resolved-locked
No description provided.