-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non-zero exit codes with Application::shutdown()
#857
Comments
Any news on this? |
@tony-iqlusion No stress, but it would be really awesome if there would be a new patch release (if applicable) for this, so we can use this in |
There are some additional changes I'd like to make first, but I will try to get another release out soon |
Great, thank you! <3 Anything oneself can/you need help with? |
Don't want to put any pressure. Just wanted to mention that a release would help us to close an high-priority issue in https://github.com/rustic-rs/rustic |
Currently,
shutdown
always returns0
as exit code:abscissa/core/src/application.rs
Lines 160 to 169 in 31bdced
As a user of
abscissa
I would expect the following to return a non-zero exit code, when I passShutdown::Crash
, though.What's the opinion on changing that, to allow non-zero exit codes? We could directly return and call
process::exit()
ourselves, for sure. I'm unsure, though, whether it wouldn't be nice to stay withinabscissa
to let all the other components shutting down gracefully, while still exiting with a non-zero exit code.EDIT:
Maybe utilizing https://docs.rs/exitcode/1.1.2/exitcode/ these numbers?
The text was updated successfully, but these errors were encountered: