-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement FromStr for SecretString #1234
Comments
Since the conversion is infallible, I've added a |
@tony-iqlusion We are using envconfig crate and it requires FromStr to be implemented so it won't work having just From<&str>. The previous secrecy versions had FromStr implemented, now we can't upgrade secrecy so I'm wondering If we can add back FromStr implementation. I'm happy to create a PR if you agree to add FromStr. |
Ok, we can add a |
when do you plan to publish this? i'm also running into this during update |
This could be convenient for use cases like using secrecy + https://github.com/greyblake/envconfig-rs that rely on FromStr
The text was updated successfully, but these errors were encountered: