Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor scripts to store pathlib.Path objects instead of raw strings #11055

Closed
ScottTodd opened this issue Nov 4, 2022 · 0 comments · Fixed by #11247
Closed

Refactor scripts to store pathlib.Path objects instead of raw strings #11055

ScottTodd opened this issue Nov 4, 2022 · 0 comments · Fixed by #11247
Labels
cleanup 🧹

Comments

@ScottTodd
Copy link
Member

Discussed on #11048

We have several scripts that process and store paths, along with tests for these scripts. Raw strings are tricky to manipulate and compare (especially across Linux/Windows and when symlinks are involved). We should refactor these scripts to use pathlib objects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup 🧹
Projects
No open projects
IREE
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace string path with pathlib in benchmark tools pzread/iree
1 participant
@ScottTodd