Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[p2] Incorrect accuracy display in the return of "gov query-params" #1414

Closed
shilei-wang opened this issue May 6, 2019 · 1 comment
Closed
Assignees
Labels
bug Something isn't working client

Comments

@shilei-wang
Copy link
Contributor

shilei-wang commented May 6, 2019

In non-json mode, output (slashing/min_signed_per_window) accuracy is incorrect


To Reproduce

json mode (correct):
iriscli gov query-params --trust-node --module=slashing -o=json --indent
{
"type": "irishub/slashing/Params",
"value": {
"max_evidence_age": "51840",
"signed_blocks_window": "10",
min_signed_per_window: 0.5000000000,
"double_sign_jail_duration": "172800000000000",
"downtime_jail_duration": "86400000000000",
"censorship_jail_duration": "172800000000000",
"slash_fraction_double_sign": "0.0100000000",
"slash_fraction_downtime": "0.0000000000",
"slash_fraction_censorship": "0.0000000000"
}
}

non-json mode (incorrect):
iriscli gov query-params --trust-node --module=slashing
Slashing Params:
Max Evidence Age: 51840
Signed Blocks Window: 10
Min Signed Per Window: 5000000000
DoubleSign Jail Duration: 48h0m0s
Downtime Jail Duration: 24h0m0s
Censorship Jail Duration: 48h0m0s
Slash Fraction DoubleSign: 0.0100000000
Slash Fraction Downtime: 0.0000000000
Slash Fraction Censorship: 0.0000000000

@shilei-wang shilei-wang added the bug Something isn't working label May 6, 2019
@shilei-wang shilei-wang changed the title [p3] Incorrect accuracy display in the return of "gov query-params" [p2] Incorrect accuracy display in the return of "gov query-params" May 6, 2019
@haifengxi haifengxi assigned chengwenxi and unassigned haifengxi May 6, 2019
@shilei-wang
Copy link
Contributor Author

confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client
Projects
None yet
Development

No branches or pull requests

3 participants