Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[p1] Shutting down tmkms when a validator enters proposal round crashes the app #1460

Closed
shilei-wang opened this issue May 22, 2019 · 1 comment
Assignees
Labels
bug Something isn't working tendermint

Comments

@shilei-wang
Copy link
Contributor

shilei-wang commented May 22, 2019

Describe the bug
Panic happened while trying to shutdown tmkms server in proposal round.

NOTICE!! This “CONSENSUS FAILURE” will not affect the consensus of other nodes.

Screenshots
[22056-05-22|19:58:40.607] CONSENSUS FAILURE!!! module=consensus err="runtime error: invalid memory address or nil pointer dereference" stack="goroutine 2109 [running]:\nruntime/debug.Stack(0x58930c0, 0x3ff0000000000000, 0x2)\n\t/usr/local/Cellar/go/1.12.5/libexec/src/runtime/debug/stack.go:24 +0x9d\ngit.luolix.top/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine.func2(0xc0000adc00, 0x4e5f5a8)\n\t/Users/sherlock/go/pkg/mod/github.com/irisnet/tendermint@v0.28.0/consensus/state.go:584 +0x12a\npanic(0x4ba8800, 0x585c250)\n\t/usr/local/Cellar/go/1.12.5/libexec/src/runtime/panic.go:522 +0x1b5\ngit.luolix.top/tendermint/tendermint/privval.(*RemoteSignerClient).GetPubKey(...)\n\t/Users/sherlock/go/pkg/mod/github.com/irisnet/tendermint@v0.28.0/privval/remote_signer.go:55\ngit.luolix.top/tendermint/tendermint/privval.(*SocketVal).GetPubKey(0xc0001bb100, 0x0, 0x0)\n\t/Users/sherlock/go/pkg/mod/github.com/irisnet/tendermint@v0.28.0/privval/client.go:89 +0x72\ngit.luolix.top/tendermint/tendermint/consensus.(*ConsensusState).enterPropose(0xc0000adc00, 0x163, 0x0)\n\t/Users/sherlock/go/pkg/mod/github.com/irisnet/tendermint@v0.28.0/consensus/state.go:846 +0x594\ngit.luolix.top/tendermint/tendermint/consensus.(*ConsensusState).enterNewRound(0xc0000adc00, 0x163, 0x0)\n\t/Users/sherlock/go/pkg/mod/github.com/irisnet/tendermint@v0.28.0/consensus/state.go:796 +0x7d2\ngit.luolix.top/tendermint/tendermint/consensus.(*ConsensusState).addVote(0xc0000adc00, 0xc003b18be0, 0xc00086ea20, 0x28, 0x6241460, 0xc0008e7ad8, 0xc0008e7b18)\n\t/Users/sherlock/go/pkg/mod/github.com/irisnet/tendermint@v0.28.0/consensus/state.go:1635 +0xadc\ngit.luolix.top/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote(0xc0000adc00, 0xc003b18be0, 0xc00086ea20, 0x28, 0x106, 0x106, 0x0)\n\t/Users/sherlock/go/pkg/mod/github.com/irisnet/tendermint@v0.28.0/consensus/state.go:1484 +0x5c\ngit.luolix.top/tendermint/tendermint/consensus.(*ConsensusState).handleMsg(0xc0000adc00, 0x4fd6180, 0xc0015a1798, 0xc00086ea20, 0x28)\n\t/Users/sherlock/go/pkg/mod/github.com/irisnet/tendermint@v0.28.0/consensus/state.go:663 +0x6cc\ngit.luolix.top/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine(0xc0000adc00, 0x0)\n\t/Users/sherlock/go/pkg/mod/github.com/irisnet/tendermint@v0.28.0/consensus/state.go:620 +0x65f\ncreated by github.com/tendermint/tendermint/consensus.(*ConsensusState).OnStart\n\t/Users/sherlock/go/pkg/mod/github.com/irisnet/tendermint@v0.28.0/consensus/state.go:306 +0x12b\n"
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x46f9336]

goroutine 82 [running]:
github.com/tendermint/tendermint/privval.(*RemoteSignerClient).Ping(0x0, 0x4e60980, 0xc0001bb168)
/Users/sherlock/go/pkg/mod/github.com/irisnet/tendermint@v0.28.0/privval/remote_signer.go:133 +0x36
github.com/tendermint/tendermint/privval.(*SocketVal).Ping(0xc0001bb100, 0x0, 0x0)
/Users/sherlock/go/pkg/mod/github.com/irisnet/tendermint@v0.28.0/privval/client.go:113 +0x7a
github.com/tendermint/tendermint/privval.(*SocketVal).OnStart.func1(0xc0001bb100)
/Users/sherlock/go/pkg/mod/github.com/irisnet/tendermint@v0.28.0/privval/client.go:152 +0xc8
created by github.com/tendermint/tendermint/privval.(*SocketVal).OnStart
/Users/sherlock/go/pkg/mod/github.com/irisnet/tendermint@v0.28.0/privval/client.go:148 +0x269

version 0.14.0

@shilei-wang shilei-wang added the bug Something isn't working label May 22, 2019
@haifengxi haifengxi changed the title [p1] CONSENSUS FAILURE!! occurred if a validator who is in his proposal round , and at the mean time , try to shutdown tmkms server. [p1] Shutting down tmkms when a validator enters proposal round crashes the app Jun 12, 2019
@shilei-wang
Copy link
Contributor Author

Cannot reproduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tendermint
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants