Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet writer should default to writing pages with DataPageV1 for better compatibility with other Parquet readers #78

Open
rdmello opened this issue Jan 7, 2019 · 2 comments

Comments

@rdmello
Copy link

rdmello commented Jan 7, 2019

Hello,

I am investigating a parquet-cpp issue where the data in a file written by the parquetjs library is not readable by the parquet-cpp library. This also seems to be related to another open issue in the parquetjs library: #75 .

This is happening since parquetjs writes data pages using the DataPageV2 format, which doesn't appear to have widespread support among most Parquet readers, like parquet-cpp. I have opened a pull request in parquet-cpp to improve its DataPageV2 support here.

I see that there is some logic in parquetjs' writer.js to write DataPageV1 pages instead, but this is only accessible through the ParquetEnvelopeWriter API. It would be better if the ParquetWriter class could also default to writing DataPageV1 pages to improve compatibility with other Parquet readers.

@ZJONSSON
Copy link
Contributor

ZJONSSON commented Jan 8, 2019

see also ZJONSSON#24 (comment)

@dobesv
Copy link
Contributor

dobesv commented Dec 13, 2019

BigQuery also does not support data page v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants