Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!j-* should not return in alphabetical order #178

Closed
job opened this issue Jan 27, 2019 · 1 comment
Closed

!j-* should not return in alphabetical order #178

job opened this issue Jan 27, 2019 · 1 comment
Assignees
Labels
bug Something isn't working later Planned for a later time
Milestone

Comments

@job
Copy link
Member

job commented Jan 27, 2019

This is mostly cosmetic, but we don't know what people depend on the ordering of the !j-* command.

The order observed here:

hanna:~ job$ whois -h irrd01.ip.gin.ntt.net '!s-lc'
A123
NTTCOM,INTERNAL,RADB,RIPE,RIPE-NONAUTH,ALTDB,BELL,LEVEL3,RGNET,APNIC,JPIRR,ARIN,BBOI,TC,AFRINIC,ARIN-WHOIS,RPKI,REGISTROBR
C

should be used in the j- command

hanna:~ job$ whois -h irrd01.ip.gin.ntt.net '!j-*'
A275
AFRINIC:Y:-
ALTDB:Y:48228-48363
APNIC:Y:-
ARIN:Y:124539-127020
ARIN-WHOIS:N:-
BBOI:Y:8580-8758
BELL:Y:-
INTERNAL:Y:-
JPIRR:Y:-
LEVEL3:Y:788058-788397
NTTCOM:Y:1000597-1000905
RADB:Y:4056392-4064452
REGISTROBR:N:-
RGNET:Y:-
RIPE:Y:-
RIPE-NONAUTH:Y:-
RPKI:N:-
TC:Y:18980-19087
C
@job job added bug Something isn't working later Planned for a later time labels Jan 27, 2019
@mxsasha mxsasha self-assigned this Jan 29, 2019
@mxsasha mxsasha added this to the IRRD 4.0.0 milestone Jan 29, 2019
@mxsasha
Copy link
Collaborator

mxsasha commented Jan 30, 2019

Note that when a specific source list is provided, we retain the source order in which it was queried. For example:

!jARIN,NTTCOM,APNIC
A65
ARIN:Y:98854-127729
NTTCOM:Y:988873-1002668
APNIC:Y:98854-123078
C

That seemed to me like good behaviour. In other words, the fix only affects the order of '!j-*', on purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working later Planned for a later time
Projects
None yet
Development

No branches or pull requests

2 participants