Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source list order is not honored #196

Closed
troy2914 opened this issue Feb 7, 2019 · 0 comments
Closed

source list order is not honored #196

troy2914 opened this issue Feb 7, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@troy2914
Copy link
Member

troy2914 commented Feb 7, 2019

when expanding AS9498:AS-BHARTI-IN in APNIC (via !a6AS9498:AS-BHARTI-IN)
1804:f8c::/32 from AS263591 in BBOI is not included.

AS-WIOCC in RIPE is included by AS9498:AS-BHARTI-IN (doing an !a6AS-WIOCC does return 1804:f8c::/32)

AS-CN2 (included from AS-WIOCC) exists in NTTCOM, RADB, and APNIC. NTTCOM and RADB entries contain AS-G8 (doing an !a6AS-CN2 does return 1804:f8c::/32)

AS-G8 exists in NTTCOM, RADB, BBOI. All sources included AS263591

All those were run with the default source list.

I notice in the postgres log that the order by is now:
ORDER BY CASE WHEN (rpsl_objects.source = 'APNIC') THEN -1 WHEN (rpsl_objects.source = 'NTTCOM') THEN 1 WHEN (rpsl_objects.source = 'INTERNAL') THEN 2 WHEN (rpsl_objects.source = 'RADB') THEN 3 WHEN (rpsl_objects.source = 'RIPE') THEN 4 WHEN (rpsl_objects.source = 'RIPE-NONAUTH') THEN 5 WHEN (rpsl_objects.source = 'ALTDB') THEN 6 WHEN (rpsl_objects.source = 'BELL') THEN 7 WHEN (rpsl_objects.source = 'LEVEL3') THEN 8 WHEN (rpsl_objects.source = 'RGNET') THEN 9 WHEN (rpsl_objects.source = 'APNIC') THEN 10 WHEN (rpsl_objects.source = 'JPIRR') THEN 11 WHEN (rpsl_objects.source = 'ARIN') THEN 12 WHEN (rpsl_objects.source = 'BBOI') THEN 13 WHEN (rpsl_objects.source = 'TC') THEN 14 WHEN (rpsl_objects.source = 'AFRINIC') THEN 15 WHEN (rpsl_objects.source = 'ARIN-WHOIS') THEN 16 WHEN (rpsl_objects.source = 'RPKI') THEN 17 WHEN (rpsl_objects.source = 'REGISTROBR') THEN 18 WHEN (rpsl_objects.source = 'TEST') THEN 19 ELSE 100000 END

Just because AS9498:AS-BHARTI-IN was found in APNIC, APNIC should not have priority. That broken priority explains why when I query objects in RIPE and NTTCOM is the proper objects are returned. The source list should not change from the initial query. Eg NTCCOM should be the lowest at 1. Whether it's the default source list, or a !s source list, you should not be changing it for
the sub-queries until there is a new !s.

@troy2914 troy2914 added the bug Something isn't working label Feb 7, 2019
@mxsasha mxsasha closed this as completed in af7035e Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant