-
Notifications
You must be signed in to change notification settings - Fork 43
Fixed issue #14 with getChildProps setting follow. from this.follow to this.... #16
base: master
Are you sure you want to change the base?
Conversation
This looks like a simple typo fix, any chance this PR might get included in a v0.1.26 minor release? |
…ream#16 fixes the underlying issue
Hi @zkat, I just wanted to ping on this PR. Assuming that following nested symlinks is the intended behavior, is there any reason this (once rebased) can't be merged? |
I need to write tests for this :< |
HI, @othiym23 Is there anything I can do to help with this? I'd be willing to write some tests if y'all have something I can reference to see how you want them. p.s. We met at Cascadia, I was the guy with the hexapod. |
Hey guys, is there any progress regarding this PR? Cheers |
@zkat @othiym23 can you address this (seemingly simple) issue. Since firebase-tools depend on this library, this completely blocks any use of symlinks in firebase projects(!). Firebase Issue: firebase/firebase-tools#22 |
I cannot believe this PR has been open for 6 years, contains a single line diff, and still hasn't been merged... I mean, I'm all for writing tests, but guys come on. As has been mentioned firebase-tools depends upon this repo and for those of us looking to structure our code in a mono-repo we need the ability to use symlinks. If there is anything myself or any of the community members can do to get this fixed upstream please lmk. |
Fixes issue #14 here with not following directories that are symlinks. Not sure what the intended design was.