Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Fixed issue #14 with getChildProps setting follow. from this.follow to this.... #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AdamMagaluk
Copy link

Fixes issue #14 here with not following directories that are symlinks. Not sure what the intended design was.

@cbraynor
Copy link

cbraynor commented Jun 3, 2014

This looks like a simple typo fix, any chance this PR might get included in a v0.1.26 minor release?

cbraynor pushed a commit to firebase/firebase-tools that referenced this pull request Jun 5, 2014
@dtex
Copy link

dtex commented Oct 13, 2015

Hi @zkat, I just wanted to ping on this PR. Assuming that following nested symlinks is the intended behavior, is there any reason this (once rebased) can't be merged?

@dtex
Copy link

dtex commented Oct 23, 2015

Hi @zkat and @othiym23 just wanted to ping on this again. Sorry to be a squeaky wheel.

@zkat
Copy link
Contributor

zkat commented Oct 30, 2015

I need to write tests for this :<

@othiym23 othiym23 assigned othiym23 and unassigned zkat Oct 30, 2015
@dtex
Copy link

dtex commented Dec 17, 2015

HI, @othiym23 Is there anything I can do to help with this? I'd be willing to write some tests if y'all have something I can reference to see how you want them.

p.s. We met at Cascadia, I was the guy with the hexapod.

@hpawe01
Copy link

hpawe01 commented May 9, 2017

Hey guys,

is there any progress regarding this PR?
Need this to use symbolic links in firebase (see firebase/firebase-tools#22).

Cheers

@D1no
Copy link

D1no commented Sep 14, 2017

@zkat @othiym23 can you address this (seemingly simple) issue. Since firebase-tools depend on this library, this completely blocks any use of symlinks in firebase projects(!).

Firebase Issue: firebase/firebase-tools#22

image

@Rojuinex
Copy link

I cannot believe this PR has been open for 6 years, contains a single line diff, and still hasn't been merged...

I mean, I'm all for writing tests, but guys come on. As has been mentioned firebase-tools depends upon this repo and for those of us looking to structure our code in a mono-repo we need the ability to use symlinks.

If there is anything myself or any of the community members can do to get this fixed upstream please lmk.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants