Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

"Allow edits from maintainers" should work on organisation repositories #1681

Open
xmo-odoo opened this issue Oct 18, 2019 · 1 comment
Open

"Allow edits from maintainers" should work on organisation repositories #1681

xmo-odoo opened this issue Oct 18, 2019 · 1 comment

Comments

@xmo-odoo
Copy link

xmo-odoo commented Oct 18, 2019 •
edited
Loading

If a contributor creates a PR from a fork living under an organisation (rather than an individual), "allow edits from maintainers" is ignored and despite the "Add more commits by pushing to the <xxx> branch on <yyy>" note being present, it will not work unless the maintainer is explicitly added as a contributor to the source repository.
@tbraun-hk tbraun-hk mentioned this issue Feb 3, 2020
Merged
@dwijnand dwijnand mentioned this issue Feb 11, 2020
Merged
@glothriel glothriel mentioned this issue Mar 27, 2020
Closed
4 tasks
@xobs xobs mentioned this issue May 28, 2020
Merged
aikar referenced this issue in PaperMC/Paper Jun 20, 2020
@aikar
Add note to use Personal Forks and not Organization forks for PR's
ab2e8a8 
Paper will routinely modify your PR for you to rebase it on latest or take care of any minor nitpicks that we can
just solve for you instead of making you go back for a trivial item.

However, if you use an Organization for the PR, this prevents Paper from doing this, and will require us to manually
merge it and close the PR instead of it being marked as the purple merged.

We much prefer to have merged PR's show as merged, so please do not use organizations repo's for PR as GitHub sadly
does not support maintainers pushing to them.

See [https://github.com/isaacs/github/issues/1681](https://github.com/isaacs/github/issues/1681)
@sarken sarken mentioned this issue Jul 1, 2020
Merged
5 tasks
@BONNe BONNe mentioned this issue Jul 10, 2020
Merged
@annevk annevk mentioned this issue Aug 4, 2020
Closed
@JulienCochuyt JulienCochuyt mentioned this issue Aug 6, 2020
Merged
@loucyx loucyx mentioned this issue Aug 7, 2020
Merged
@asisiuc asisiuc mentioned this issue Sep 8, 2020
Closed
@nanne007 nanne007 mentioned this issue Sep 30, 2020
Closed
This was referenced Nov 29, 2020
Merged
Merged
@rly rly mentioned this issue Dec 1, 2020
Merged
6 tasks
@zaphod534 zaphod534 mentioned this issue Dec 1, 2020
Merged
10 tasks
@electrofelix electrofelix mentioned this issue Jan 7, 2021
Merged
@ali-abrar ali-abrar mentioned this issue Jan 8, 2021
Draft
5 tasks
@bmatthieu3 bmatthieu3 mentioned this issue Jan 12, 2021
Merged
@johnboyes johnboyes mentioned this issue Jan 13, 2021
Merged
@ozkriff ozkriff mentioned this issue Jan 13, 2021
Closed
@sampoder sampoder mentioned this issue Jan 20, 2021
Merged
@j0k3r j0k3r mentioned this issue Feb 1, 2021
Closed
7 tasks
@pszafer pszafer mentioned this issue Feb 9, 2021
Closed
@aethr aethr mentioned this issue Feb 18, 2021
Merged
@faust64 faust64 mentioned this issue Mar 3, 2021
Closed
@tuomashamalainen tuomashamalainen mentioned this issue Mar 9, 2021
Merged
@Hugome Hugome mentioned this issue Mar 9, 2021
Merged
4 tasks
@ahgittin ahgittin mentioned this issue Mar 10, 2021
Closed
@jonathan-golorry jonathan-golorry mentioned this issue Mar 17, 2021
Closed
@waldyrious waldyrious mentioned this issue Sep 23, 2021
Closed
@sandraros sandraros mentioned this issue Oct 17, 2021
Closed
@calebcartwright calebcartwright mentioned this issue Oct 22, 2021
Merged
7 tasks
@n4l5u0r n4l5u0r mentioned this issue Nov 19, 2021
Merged
@ZauberNerd ZauberNerd mentioned this issue Nov 26, 2021
Merged
@greg-nagy greg-nagy mentioned this issue Nov 30, 2021
Merged
4 tasks
@lukechilds lukechilds mentioned this issue Dec 29, 2021
Merged
6 tasks
@joao-paulo-parity joao-paulo-parity mentioned this issue Jan 10, 2022
Open
@yarikbratashchuk yarikbratashchuk mentioned this issue Jan 20, 2022
Merged
@spawnia spawnia mentioned this issue Feb 17, 2022
Closed
@jethron jethron mentioned this issue Feb 17, 2022
Merged
4 tasks
@razor-x razor-x mentioned this issue Mar 1, 2022
Merged
This was referenced Mar 28, 2022
Merged
Merged
@jamesmurdza jamesmurdza mentioned this issue Apr 1, 2022
Merged
@DukMastaaa DukMastaaa mentioned this issue Apr 12, 2022
Merged
@j1elo j1elo mentioned this issue Apr 28, 2022
Merged
8 tasks
@nazar-pc nazar-pc mentioned this issue Apr 29, 2022
Merged
This was referenced May 2, 2022
Closed
Merged
@brycekahle brycekahle mentioned this issue May 4, 2022
Closed
@cpoerschke cpoerschke mentioned this issue Jul 14, 2022
Merged
7 tasks
@thelink2012 thelink2012 mentioned this issue Aug 2, 2022
Closed
@owent owent mentioned this issue Aug 11, 2022
Merged
@r-token r-token mentioned this issue Sep 26, 2022
Closed
@lesteve lesteve mentioned this issue Mar 22, 2023
Merged
@ZYSzys ZYSzys mentioned this issue Jul 25, 2023
Closed
@ghost ghost mentioned this issue Jan 5, 2024
Merged
@tuantran1702 tuantran1702 mentioned this issue Apr 13, 2024
Merged
7 tasks
@Mi-La Mi-La mentioned this issue May 14, 2024
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xmo-odoo @joao-paulo-parity