Detecting "merged" Pull Requests that were not accepted with git-merge

[Wopple]

We "merge" our PRs via rebase / cherry-pick and amending commit messages with "closes #". However, this gives the PR the "closed" status as if you closed the pull request without accepting the changes. This causes our JIRA integration to think the pull request has been declined.

It would be nice if we could have a "rebased" status or perhaps another workaround so our JIRA integration can detect accepted pull requests that were not merged. Having the option to mark the PR as such through a commit message or through the website would be nice as well.

[pdilyard]

+1

[miketwo]

+1. Though I think a workaround is to re-push the altered commit to the PR branch first (using force if necessary), then merge into master.

[cvrebert]

Very similar to #2.

[c0b]

👍 for this; a lot of projects like nodejs development still favors the original linux kernel development style: some core maintainer add Reviewed-by: Acked-by: and series of those and commit and push for you, since the commit msg has somewhat changed, it's not the original commit github can't detect as merged; but the content of changes are the same

in this comment, @jasnell has to manually say Landed in 983a809 and close the PR which is inconvenient; as I think @github should detect this case and mark nodejs/node#6350 as merged automatically.

1. doc: fix broken references nodejs/node#6350 (comment)
2. nodejs/node@983a809

[Wopple]

With the ability to rebase or squash in the UI, this is mostly a non-issue now.