From bea638225aa991095f29a9e16d914effa0c134fe Mon Sep 17 00:00:00 2001
From: isaacs <i@izs.me>
Date: Fri, 3 Apr 2020 10:11:10 -0700
Subject: [PATCH] Remove unnecessary umask calls

Legacy fix for https://github.com/isaacs/node-mkdirp/issues/22
Re https://github.com/nodejs/node/issues/32321
---
 index.js        |  4 ++--
 readme.markdown |  4 ++--
 test/umask.js   | 28 ----------------------------
 3 files changed, 4 insertions(+), 32 deletions(-)
 delete mode 100644 test/umask.js

diff --git a/index.js b/index.js
index 2f12870..468d7cd 100644
--- a/index.js
+++ b/index.js
@@ -17,7 +17,7 @@ function mkdirP (p, opts, f, made) {
     var xfs = opts.fs || fs;
     
     if (mode === undefined) {
-        mode = _0777 & (~process.umask());
+        mode = _0777
     }
     if (!made) made = null;
     
@@ -62,7 +62,7 @@ mkdirP.sync = function sync (p, opts, made) {
     var xfs = opts.fs || fs;
     
     if (mode === undefined) {
-        mode = _0777 & (~process.umask());
+        mode = _0777
     }
     if (!made) made = null;
 
diff --git a/readme.markdown b/readme.markdown
index 3cc1315..fc314bf 100644
--- a/readme.markdown
+++ b/readme.markdown
@@ -37,7 +37,7 @@ Create a new directory and any necessary subdirectories at `dir` with octal
 permission string `opts.mode`. If `opts` is a non-object, it will be treated as
 the `opts.mode`.
 
-If `opts.mode` isn't specified, it defaults to `0777 & (~process.umask())`.
+If `opts.mode` isn't specified, it defaults to `0777`.
 
 `cb(err, made)` fires with the error or the first directory `made`
 that had to be created, if any.
@@ -52,7 +52,7 @@ Synchronously create a new directory and any necessary subdirectories at `dir`
 with octal permission string `opts.mode`. If `opts` is a non-object, it will be
 treated as the `opts.mode`.
 
-If `opts.mode` isn't specified, it defaults to `0777 & (~process.umask())`.
+If `opts.mode` isn't specified, it defaults to `0777`.
 
 Returns the first directory that had to be created, if any.
 
diff --git a/test/umask.js b/test/umask.js
deleted file mode 100644
index 2033c63..0000000
--- a/test/umask.js
+++ /dev/null
@@ -1,28 +0,0 @@
-var mkdirp = require('../');
-var path = require('path');
-var fs = require('fs');
-var exists = fs.exists || path.exists;
-var test = require('tap').test;
-var _0777 = parseInt('0777', 8);
-var _0755 = parseInt('0755', 8);
-
-test('implicit mode from umask', function (t) {
-    t.plan(5);
-    var x = Math.floor(Math.random() * Math.pow(16,4)).toString(16);
-    var y = Math.floor(Math.random() * Math.pow(16,4)).toString(16);
-    var z = Math.floor(Math.random() * Math.pow(16,4)).toString(16);
-    
-    var file = '/tmp/' + [x,y,z].join('/');
-    
-    mkdirp(file, function (err) {
-        t.ifError(err);
-        exists(file, function (ex) {
-            t.ok(ex, 'file created');
-            fs.stat(file, function (err, stat) {
-                t.ifError(err);
-                t.equal(stat.mode & _0777, _0777 & (~process.umask()));
-                t.ok(stat.isDirectory(), 'target not a directory');
-            });
-        })
-    });
-});