Error when deleting .git folder in windows

[satazor]

This issue only happens in windows when using rimraf 2.1.x. When using 2.0.x it works fine.
When rimraf is used to delete a git repository, it fails when removing .git/objects/pack/*.idx and *.pack files.

I've spotted this issue because I've upgraded rimraf in 0.8.x release of http://github.com/twitter/bower and windows users started to complain. After some debugging, the unlink of these files error out with EPERM. Then rimraf interprets them as a directory and some other error happens. I think this is related to the fact the older versions of rimraf tried to make the file writable before deleting it.
When I tested, I had no hanging process on those files or the .git folder.

To reproduce:
$ git clone git://github.com/satazor/SparkMD5.git

var rimraf = require('rimraf');

rimraf('SparkMD5', function (err) {
  console.log(err);
});

[feugy]

👍
I also encounter the problem, via fs-extra. I had to downgrade it to 0.4.0 who use rim-raf 2.0.2.

[ghost]

[isaacs]

If you want to chmod a dir recursively, use https://github.com/isaacs/chmodr

Note that rm -rf on the command line also fails. This is definitely bad behavior on git's part, but rimraf should not club the fs properties.

[feugy]

Sorry Isaacs, I don't understand why you spotted your chmod tools. Do you believe that changing the owner will allow rimraf to delete the git folder ?

[isaacs]

chmod is for changing the mode, not the owner. (For that, you'd need chownr.)

If you remove the read-only bit, then yes, it will delete just fine.

[paulmillr]

Brunch users on windows recently (likely after update to node 0.10) started receiving errors like this:

ENOTEMPTY, rmdir 'c:\xampp-portable\htdocs\marionette.git\objects\00']
errno: 53, code: 'ENOTEMPTY', path: 'c:\xampp-portable\htdocs\marionette\.git\objects\00'

So it fails to delete .git but there is no EPERM. Any ideas?

[isaacs]

Ah, indeed, there seems to be a bug here. Posted on #21.

[klarkc]

+1 This affects me, but in Linux.

Trying to remove test_sandbox folder:

Error: ENOTEMPTY, rmdir 'tests/test_sandbox/.git'

Looking for permission issues with this command: $ find tests/test_sandbox/ -exec getfacl -t {} \; | grep "USER", give me this:

USER   klarkc    rwx     
USER   klarkc    rwx     
USER   klarkc    rwx     
USER   klarkc    rw-     
USER   klarkc    rwx     
USER   klarkc    rwx     
USER   klarkc    rwx     
USER   klarkc    rw-     
USER   klarkc    rwx     
USER   klarkc    rwx     
USER   klarkc    rwx     
USER   klarkc    rwx     
USER   klarkc    rwx     
USER   klarkc    rwx     
USER   klarkc    rwx     
USER   klarkc    rwx     
USER   klarkc    rwx     
USER   klarkc    rwx     
USER   klarkc    rw-

So none of the files have read only permissions nor are owned by someone else.