New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closing square bracket in a doctype comment leads to an error #236

Closed

jcsahnwaldt opened this issue Jun 9, 2018 · 0 comments · Fixed by #267

jcsahnwaldt commented Jun 9, 2018

A closing square bracket in a doctype comment leads to an error in sax-js, but it's allowed by XML spec, and other parsers / validators accept it.

See test case in pull request #235 .

jcsahnwaldt mentioned this issue

tried to load kanjidic2.xml, no errors, no data either Leonidas-from-XIV/node-xml2js#140

Closed

SethFalco mentioned this issue

fix: don't throw on comment in dtd #267

Merged

isaacs closed this as completed in #267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment