Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the Transit time encoding. #6

Open
jlouis opened this issue Aug 23, 2014 · 3 comments
Open

Error in the Transit time encoding. #6

jlouis opened this issue Aug 23, 2014 · 3 comments
Labels

Comments

@jlouis
Copy link
Collaborator

jlouis commented Aug 23, 2014

Generating {transit_datetime,{0,0,1000}} fails the isomorphism test. It is encoded as a quoted "~m0" but this is obviously wrong since it is one millisecond in. So the right encoding is "~m1".

@jlouis jlouis added bug and removed bug labels Aug 23, 2014
@jlouis jlouis closed this as completed in cb84cca Aug 23, 2014
@jlouis
Copy link
Collaborator Author

jlouis commented Aug 23, 2014

This has not been fixed. It fails for {-1, 0, 1000} as well.

@jlouis jlouis reopened this Aug 23, 2014
@jlouis
Copy link
Collaborator Author

jlouis commented Sep 2, 2014

Investigated this one some more. It has to do with negative values in general and the way we map these into the Erlang time tuple. Also, it is not clear entirely how points in the past is to be handled by the Erlang time module.

@isaksky
Copy link

isaksky commented Nov 17, 2016

Have you considered just not trying to convert it? This would arguably be better, because then users can do it themselves if they have a working way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants