Setter/Getter Methods for Data Structures Defined in the RMM Spec #296
Closed
bitboom
started this conversation in
Show and tell
Replies: 1 comment
-
In relation to the topic discussed, I prefer Option 1. Structures used for RMI/RSI are primarily intended for interface purposes. Once validated upon creation, I believe it should be permissible to freely access them within the RMM. Currently, among the current setter/getter methods, the only additional validation performed involves checking the array index. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The RMM contains numerous data structures as defined in the Spec, such as
RmiRecRun
andRsiHostCall
.Currently, in the RMM, some structures have their fields' visibility set to
pub
, allowing direct access from other modules, while others are accessed throughsetter/getter methods
from different modules.I believe it would be beneficial to choose one of the following options for consistency in our codebase:
Beta Was this translation helpful? Give feedback.
All reactions